Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: add --version long argument to return PROJ version #3836

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lbartoletti
Copy link
Contributor

@lbartoletti lbartoletti commented Jul 20, 2023

The proposed --version option will enable users to easily retrieve the application's version without having to refer to documentation or resort to external means. This feature is essential for testing various behaviors and fulfilling a specific user requirement.

I have tried to adhere to the existing code conventions while implementing this feature. As of now, the changes have been applied only to one utility, but if it's OK, I'll extend the same modifications to other apps.

cc @Guts

@lbartoletti lbartoletti force-pushed the add_version_long_argument branch from 3a68d7d to fb9e68f Compare July 20, 2023 08:42
@kbevers
Copy link
Member

kbevers commented Jul 20, 2023

I think this is a good idea. Can you please include an example here? Also, remember to adjust the docs as well so that this feature isn't a secret.

@rouault
Copy link
Member

rouault commented Jul 20, 2023

The gie and cct utilities already implement --version with the following output:

$ bin/gie --version
gie: Rel. 9.3.0, September 1st, 2023
$ bin/cct --version
cct: Rel. 9.3.0, September 1st, 2023

I guess with your proposed change, you'd reduce this to 9.3.0
I don't think that change would be critically breaking. Perhaps @busstoptaktik has an opinion regarding this

You could also change proj_info() in src/4D_api.cpp to change "info.version = version;" to "info.version = pj_get_version()"

@kbevers
Copy link
Member

kbevers commented Jul 20, 2023

I wouldn't mind it if the date disappeared from the --version outputs of the apps. It's an annoying thing to maintain in releases.

@rouault
Copy link
Member

rouault commented Jul 20, 2023

It's an annoying thing to maintain in releases.

proj_info() reports 2 fields ".version=X.Y.Z" and ".release=Rel. X.Y.Z, date"

@Guts
Copy link

Guts commented Jul 20, 2023

Thanks @lbartoletti!

To give context, I need to identify the installed PROJ version to adapt some parts of my logic. After some research, I've ended on this:

import re
import subprocess

proj_output = check_output(["proj"], stderr=STDOUT, text=True)
version_match = re.search(r"Rel\. ([0-9.]+)", proj_output):
if version_match:
    print(version_match.group(1))

But I did not know cie and cct!

See also:

@busstoptaktik
Copy link
Member

Perhaps @busstoptaktik has an opinion regarding this

@rouault this is one of the few things I cannot talk myself into having an opinion of 🙂 - but thanks for pinging me on the subject!

@snowman2
Copy link
Contributor

There are quite a few implementations for this depending on the program. One option to consider could be to provide a simple version (easier to parse for the use case of this PR) and a more verbose version like Python does.

$ python --version
Python 3.10.10
$ python -V
Python 3.10.10
$ python -VV
Python 3.10.10 | packaged by conda-forge | (main, Mar 24 2023, 20:08:06) [GCC 11.3.0]

@snowman2
Copy link
Contributor

snowman2 commented Jul 20, 2023

Side note:

$ proj
Rel. 9.1.1, December 1st, 2022
usage: proj [-bdeEfiIlmorsStTvVwW [args]] [+opt[=arg] ...] [file ...]

@snowman2
Copy link
Contributor

Code pyproj uses to get the proj version.

@jmckenna
Copy link
Contributor

This is so needed, thank-you @lbartoletti for pushing this.

@jmckenna
Copy link
Contributor

(initially reported at #2640 )

@lbartoletti
Copy link
Contributor Author

There are quite a few implementations for this depending on the program. One option to consider could be to provide a simple version (easier to parse for the use case of this PR) and a more verbose version like Python does.

$ python --version
Python 3.10.10
$ python -V
Python 3.10.10
$ python -VV
Python 3.10.10 | packaged by conda-forge | (main, Mar 24 2023, 20:08:06) [GCC 11.3.0]

Indeed, my_soft --version should return my_soft X.Y.Z and not only X.Y.Z. Long version, could the actual one aka pg_get_release() : app_name: Rel. 9.3.0, September 1st, 2023

However, in our case, -VV is not possible, since it's used for verbosity in proj app.

May I suggest:

  • app_name --version: app_name X.Y.Z, so proj --version: proj 9.3.0
  • app_name --release (or --long-version?): app_name: Rel. 9.3.0, September 1st, 2023
  • app_name --short-version (or --version-number? --version-semver?): 9.3.0

Guts added a commit to geotribu/website that referenced this pull request Jul 24, 2023
@rouault
Copy link
Member

rouault commented Jul 24, 2023

Personally, I would just stick with below for the sake of simplicity (most more popular utilities than the PROJ ones have just --version, so it might be over-engineered to offer 3 variants for PROJ...):

  • app_name --version: app_name X.Y.Z, so proj --version: proj 9.3.0

The long version with the release date doesn't bring that much, given the release date is something that is a 1:1 match with the version number.

@jmckenna
Copy link
Contributor

As a packager, this release date causes confusion to users (the date is often in the future, which causes confusion for the user, and grief for the packager). It would be good to not include this, in any utility.

@kbevers
Copy link
Member

kbevers commented Jul 24, 2023

It would be good to not include this, in any utility.

Can someone give an educated guess as to what the impact of changing the output of cct --version and gie --version is? Have people been relying on these two to get the version number in a simpler way than using proj? If we think a limited number of users rely on this I am happy to change it but we shouldn't do it if it forces a lot of people to change existing workflows.

@lbartoletti lbartoletti force-pushed the add_version_long_argument branch from 9245703 to aff3250 Compare July 24, 2023 14:24
@lbartoletti lbartoletti marked this pull request as ready for review July 27, 2023 08:43
@github-actions
Copy link
Contributor

The PROJ project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last two months and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add terminal output examples if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale label Sep 26, 2023
@lbartoletti
Copy link
Contributor Author

Not staled

@github-actions github-actions bot removed the stale label Sep 28, 2023
Copy link
Contributor

The PROJ project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last two months and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add terminal output examples if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale label Nov 27, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 2 months. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the PROJ project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Dec 4, 2023
@Guts
Copy link

Guts commented Dec 4, 2023

Still interested in this feature and homogenization work.

@kbevers
Copy link
Member

kbevers commented Dec 4, 2023

I agree that this is a sane and useful change but since I haven't received any feedback to this

Can someone give an educated guess as to what the impact of changing the output of cct --version and gie --version is? Have people been relying on these two to get the version number in a simpler way than using proj? If we think a limited number of users rely on this I am happy to change it but we shouldn't do it if it forces a lot of people to change existing workflows.

I can't really make a decision on how to proceed. For now I am inclined to not merge this PR and instead streamline the version options of the various CLI utilities in a future 10.0 release.

@jmckenna
Copy link
Contributor

jmckenna commented Dec 4, 2023

@kbevers can you leave this PR open and possibly add a label to it of "10.0 release" ? I am sure that @lbartoletti can adapt the changes to anything that you need for 10.0

Thanks for all of this effort @lbartoletti, it is very useful to the community.

@mwtoews mwtoews added pinned Prevent stale-bot from closing an issue and removed stale labels Dec 6, 2023
@mwtoews mwtoews added this to the 10.0.0 milestone Dec 6, 2023
@mwtoews mwtoews reopened this Dec 6, 2023
@DeflateAwning
Copy link
Contributor

Well that's funny. Just opened a feature request issue for this exact feature. Happy to see it's implemented!

Fixes #3980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Prevent stale-bot from closing an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --version CLI arg to all commands (e.g., proj, projsync, etc.)
9 participants