OpenFileGDB: Fixed the problem of not excluding straight line segments when parsin… #10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dingsl-giser Could you please provide a minimum reproducer for that (ideally one single geometry), so a regression test can be added |
@rouault This is a circular arc polyline in filegdb with an IsLine attribute I created, you can test it. |
rouault
pushed a commit
to rouault/gdal
that referenced
this pull request
Sep 13, 2024
|
Thanks, I've picked your commit and added an automate test based on your test dataset. Closing this PR as superseded per #10791 |
rouault
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem of not excluding straight line segments when parsing arcs.
What does this PR do?
Fixed the problem of not excluding straight line segments when parsing circular arcs as
CURVE_ARC_INTERIOR_POINTtype.What are related issues/pull requests?
When using openfilegdb driver to parse circular arc data in filegdb, circular arc is mistakenly parsed as
CURVE_ARC_INTERIOR_POINTwhen it is a line.ArcGIS:
QGIS:
This is the result of parsing the arc control point. It is actually a line, but it is classified as
CURVE_ARC_INTERIOR_POINT: