Fix issue with gdal_viewshed with gcc 9.4 in debug mode (master only) #10826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tool=helgrind autotest/cpp/gdal_unit_test --gtest_filter=test_cpl.CPLWorkerThreadPool' happy (master only) Related to OSGeo#10825
…n of NotifyQueue symbols, leading to mutex corruption Fixes OSGeo#10825
elpaso
reviewed
Sep 18, 2024
| Window oCurExtent; | ||
| DatasetPtr poDstDS; | ||
| GDALRasterBand *pSrcBand; | ||
| Window oOutExtent{}; |
There was a problem hiding this comment.
I'm curious: what changes here? Isn't the default ctor called in both cases?
There was a problem hiding this comment.
The help please -Weffc++ given that the constructor no longer explicitly initialize those members.
elpaso
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10825