docker: print HTTP errors on failure

[pjonsson]

What does this PR do?

The -q parameter to wget makes it completely
silent, even on faliure which gives build errors
that are difficult to diagnose. Someone
else had the same problem 15 years ago:

https://serverfault.com/questions/70889/wget-to-print-errors-but-nothing-otherwise

and the easiest way to robustly print
errors but nothing else seems to be
to use curl instead.

Since the docker images already include
curl, switch them to use that instead.

What are related issues/pull requests?

I'm getting intermittent build failures when building GDAL images. I can't reproduce the problem, but network-related operations have failed before (#9571), so print an error when things go wrong.

No issue filed.

Tasklist

• ADD YOUR TASKS HERE
• Make sure code is correctly formatted (cf pre-commit configuration)
• Add test case(s)
• Add documentation
• Updated Python API documentation (swig/include/python/docs/)
• Review
• Adjust for comments
• All CI builds and checks have passed

Environment

Provide environment details, if relevant:

• OS:
• Compiler:

[pjonsson]

Tested by building all images locally for the 3.9.2 release, and that worked except ubuntu-full which failed because of PDFium changes. Cherry-picked the commit to release/3.9 branch to build ubuntu-full image, and that worked.

I realize 3.9.3 is really close, but is it possible to get this into 3.9.3?

[rouault]

The backport to release/3.9 failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply 37ff70389c... docker: print HTTP errors on failure
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout

Auto-merging docker/alpine-normal/Dockerfile
CONFLICT (content): Merge conflict in docker/alpine-normal/Dockerfile
Auto-merging docker/alpine-small/Dockerfile
Auto-merging docker/ubuntu-full/Dockerfile
CONFLICT (content): Merge conflict in docker/ubuntu-full/Dockerfile
Auto-merging docker/ubuntu-full/bh-gdal.sh
Auto-merging docker/ubuntu-full/bh-proj.sh
Auto-merging docker/ubuntu-small/Dockerfile

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.9 release/3.9
# Navigate to the new working tree
cd .worktrees/backport-release/3.9
# Create a new branch
git switch --create backport-10929-to-release/3.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 37ff70389c28228773a1ab3cc1b137ddee2c346d
# Push it to GitHub
git push --set-upstream origin backport-10929-to-release/3.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.9

Then, create a pull request where the base branch is release/3.9 and the compare/head branch is backport-10929-to-release/3.9.

[rouault]

cherry-picked to 3.9 per ffa080c