Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sparse checkout of addons in
g.extension
implemented in OSGeo/grass#2895, not all subdirs of the repository exist at all time.Runing make in a directory below module level is thus likely to fail. This PR should make sure that make is run in all subdirs that contain a Makefile. And instead of hardcoded directory names, relevant subdirs are identified with the
find
command line tool.When
g.extension
is improved to support also the installation of multiple AddOns (which now should be relatively straight forward on UNIX like systems) then make should be run at the root of the addon repository to install all downloaded addons.Are find, basename, dirname and xargs available on all relevant UNIX like platforms*?
It seems Mac OS has those (but I have only Fedora and Ubuntu to test).
*On MS Windows addons are not compiled anyway.