contributing: Add instructions on unit tests #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ldesousa
commented
Jun 4, 2023
ldesousa
commented
- Friendly text (hopefully) expanded from logs in the first code sprint day.
- Dedicated file to simplify review, but could be a section in an existing file. Which?
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
veroandreo
approved these changes
Jun 5, 2023
neteler
reviewed
Jun 5, 2023
neteler
reviewed
Jun 5, 2023
neteler
reviewed
Jun 5, 2023
wenzeslaus
requested changes
Jun 5, 2023
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Markus Neteler <neteler@osgeo.org>
neteler
reviewed
Jun 7, 2023
Co-authored-by: Markus Neteler <neteler@osgeo.org>
neteler
approved these changes
Jun 8, 2023
wenzeslaus
reviewed
Jun 10, 2023
There was a problem hiding this comment.
The content is good, but it is not linked from anywhere. A link to this file needs to be included in CONTRIBUTING.md to lead contributors to it.
Additionally, the UNIT_TESTS.md file in root is without a precedent. In the code repo, we have doc/development/submitting/. What about introducing something like that here?
|
@wenzeslaus the checks are passing and the changes are applied. Would you consider merging this PR? |
wenzeslaus
approved these changes
Jul 15, 2023
wenzeslaus
changed the title
cwhite911
pushed a commit
to cwhite911/grass-addons
that referenced
this pull request
Sep 19, 2023
Friendly text expanded from notes in the first day of GRASS Community Meeting Prague 2023.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.