CI: switch to ubuntu-22.04 image to avoid timeout

[neteler]

Since the older ubuntu-20.04 image based runs commonly time-out, here an attempt with the current ubuntu-22.04 image.

See also: https://github.com/actions/runner-images

[neteler]

Mhh, this triggers unrelated other issues:

gcc  -std=gnu11 -fPIC -Wall -Wno-error=maybe-uninitialized -Werror  -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include   -I/usr/include/gdal -I/usr/include  -DPACKAGE=\""grasslibs"\"     -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -DRELDIR=\"lib/ogsf\" -o OBJ.x86_64-pc-linux-gnu/gs2.o -c gs2.c
gs2.c: In function ‘GS_get_distance_alongsurf’:
gs2.c:3296:5: error: ‘gsd_real2surf’ accessing 12 bytes in a region of size 8 [-Werror=stringop-overflow=]
 3296 |     gsd_real2surf(gs, p1);
      |     ^~~~~~~~~~~~~~~~~~~~~
gs2.c:3296:5: note: referencing argument 2 of type ‘float *’
In file included from /home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/ogsf.h:539,
                 from gs2.c:48:
/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/defs/ogsf.h:569:6: note: in a call to function ‘gsd_real2surf’
  569 | void gsd_real2surf(geosurf *, Point3);
      |      ^~~~~~~~~~~~~
gs2.c:3297:5: error: ‘gsd_real2surf’ accessing 12 bytes in a region of size 8 [-Werror=stringop-overflow=]
 3297 |     gsd_real2surf(gs, p2);
      |     ^~~~~~~~~~~~~~~~~~~~~
gs2.c:3297:5: note: referencing argument 2 of type ‘float *’
In file included from /home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/ogsf.h:539,
                 from gs2.c:48:
/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/defs/ogsf.h:569:6: note: in a call to function ‘gsd_real2surf’
  569 | void gsd_real2surf(geosurf *, Point3);
      |      ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

[nilason]

Mhh, this triggers unrelated other issues:

Probably caused by newer and stricter version of gcc and/or glibc.

Following warnings are causing error (with -Werror):

• -Wstringop-overflow=
• -Warray-parameter=
• -Wclass-memaccess (will be fixed with r.terraflow: use default #2660)

[nilason]

Mhh, this triggers unrelated other issues:

Probably caused by newer and stricter version of gcc and/or glibc.

Following warnings are causing error (with -Werror):

• -Wstringop-overflow=
• -Warray-parameter=
• -Wclass-memaccess (will be fixed with r.terraflow: use default #2660)

-Wstringop-overflow= and -Warray-parameter= warnings will be fixed by #2733.

[neteler]

Thanks so much, @nilason !

[neteler]

Yay, also the two Ubuntu CI runs finished successfully - no timeout!

[nilason]

Currently the Ubuntu based builds are failing badly, just restarted 'GCC' to see if this PR has the same issue. Indeed it has.

[neteler]

...
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/p/proj/proj-bin_8.2.1-1_amd64.deb  Unable to connect to azure.archive.ubuntu.com:http: [IP: 52.252.75.106 80]
...

:-(

[nilason]

actions/runner-images#6911 looks like being related to this.

[nilason]

Both Ubuntu 20.04 and 22.04 images were updated Jan 9:
https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20230109.1
https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20230109.1

[nilason]

Or this actions/runner-images#6913

[nilason]

By the look of it, it works again.

[neteler]

Any objections to merge this PR?

[nilason]

I have no objections, we have the CentOS runner for testing on older systems, no?. If this indeed solves the timeout issues -- even better.

[neteler]

we have the CentOS runner for testing on older systems, no?

Yes and no:

• without tests: https://github.com/OSGeo/grass/blob/main/.github/workflows/build_centos.sh
• with tests: https://github.com/OSGeo/grass/blob/main/.github/workflows/ubuntu.yml

However, we will check if the code compiles on the older Centos runner while - with this PR - running the tests on the recent Ubuntu runner which doesn't timeout. And keeping the old Ubuntu runner which mostly time-outs doesn't help much.

[nilason]

Fair enough. Maybe we can try this for some time, to see if it consistently works on a newer system and revert to the 20.04 if it doesn't.

[neteler]

So, let's try! Merging...