-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.extension: show fatal message if installed Add-On doesn't exists in the repository #2916
g.extension: show fatal message if installed Add-On doesn't exists in the repository #2916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. ANd thanks for the quick fix, @tmszi !
The code looks good to me. One could discuss if this should be an error or a warning message (when the attempts to download and compile are skipped). But for now, fatal seems right.
The suggested changes are just that, suggestions. So feel free to ignore.
BTW, you may add a test case for this issue to the download test! |
Yes, you are right, I added it. |
To be backported with #2895 |
Describe the bug
If you try install install non exists Add-On, g.extension module fail.
To Reproduce
Steps to reproduce the behavior:
g.extension non_exists_addon
Expected behavior
Fatal message should be printed.
System description (please complete the following information):