Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.extension: fix extracting Git version string #2929

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Apr 21, 2023

Describe the bug
Installing extension via g.extension module fail.

To Reproduce
Steps to reproduce the behavior:

  1. Try to install some extension g.extension db.join
  2. See error
in _get_version
    return float(
           ^^^^^^
ValueError: could not convert string to float: 'Git-143)'

Expected behavior
Installing extension via g.extension module should work without error message.

System description:

  • Operating System: macOS
  • GRASS GIS version 8.3.dev

Additional context
To be backported with #2895.

@tmszi tmszi added bug Something isn't working backport_needed macOS macOS specific Python Related code is in Python labels Apr 21, 2023
@tmszi tmszi added this to the 8.3.0 milestone Apr 21, 2023
@tmszi tmszi requested a review from ninsbl April 21, 2023 18:41
@nilason
Copy link
Contributor

nilason commented Apr 21, 2023

Mac runner fails with WARNING: The download of the commit from the GitHub API server wasn't successful, <rate limit exceeded>. Wasn't the use of git a way to circumvent this?

@tmszi
Copy link
Member Author

tmszi commented Apr 22, 2023

Mac runner fails with WARNING: The download of the commit from the GitHub API server wasn't successful, <rate limit exceeded>. Wasn't the use of git a way to circumvent this?

Yes you are right, but it is another PR #2717.

@nilason
Copy link
Contributor

nilason commented Apr 24, 2023

Have not tested, but the regex looks good to me!

@tmszi tmszi merged commit 41288a6 into OSGeo:main Apr 25, 2023
@tmszi tmszi deleted the g_extension-fix-parse-git-version branch April 25, 2023 04:15
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS macOS specific Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants