-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.stats: add JSON output #3884
base: main
Are you sure you want to change the base?
r.stats: add JSON output #3884
Conversation
@kritibirda26 let's pick up on |
Makes sense @cwhite911 |
I have added a comment on the r.report PR to discuss the schema further. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
The codecov shouldn't be sending comments, it was explicitly disabled in config. Is it because the branch doesn't include the config file (not enough updated from main)? |
Seems like it was the case.. |
Using parson, add JSON output support to r.stats module.
@cwhite911 The PR is ready for review. |
Before merging, can you make sure that your PRs are either formatted according to clang format 18 (changed 2 days ago), or merged from main? |
Using parson, add JSON output support to r.stats module.
For cell stats, the output looks like:
For raw stats, the output looks like:
The
labels
array has the numerical value, categorical name, and the name of the inputs associated with the stat. I am unsure if these fields can be named better.Once the JSON format is decided, I will add tests and update the documentation as well.