style(gui): Fixes literal-membership (PLR6201) #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concerns Pylint rule "use-set-for-membership / R6201" Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/`.
ninsbl
approved these changes
Jun 30, 2024
echoix
changed the title
cyliang368
pushed a commit
to cyliang368/grass
that referenced
this pull request
Jul 1, 2024
* style(gui/wxpython): Fixes literal-membership (PLR6201) Concerns Pylint rule "use-set-for-membership / R6201" Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/`. * style: Apply single element in set formatting
Merged
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
* style(gui/wxpython): Fixes literal-membership (PLR6201) Concerns Pylint rule "use-set-for-membership / R6201" Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/`. * style: Apply single element in set formatting
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
* style(gui/wxpython): Fixes literal-membership (PLR6201) Concerns Pylint rule "use-set-for-membership / R6201" Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/`. * style: Apply single element in set formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns Pylint rule "use-set-for-membership / R6201"
Using
ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/.Part of the effort to introduce Pylint 3.x for #3921
Uses the fixes provided for ruff rule literal-membership (PLR6201) to fix part of Pylint's "use-set-for-membership / R6201".
I reverted some changes when I wasn't completely sure if the preconditions for this refactor were met, as described in the docs of the rule. One of these is that the objects must be hashable to be in a set. If there are any that you are unsure, I'll simply remove it from the PR, as it isn't exhaustive yet. It still helps to have less linter ignores comments to add afterwards (to have Pylint 3.x not fail).
The changes are limited to
gui/wxpythonto limit the review scope.