-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 and Migrate to Xarray DataTree #1419
Support Python 3.12 and Migrate to Xarray DataTree #1419
Conversation
…work with rendertree
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
===========================================
- Coverage 83.52% 72.92% -10.60%
===========================================
Files 64 37 -27
Lines 5686 4396 -1290
===========================================
- Hits 4749 3206 -1543
- Misses 937 1190 +253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I commented out |
This should be ready for review @leewujung |
"NMEA_datagram": ( | ||
["time1"], | ||
["nmea_time"], | ||
raw_nmea, | ||
{"long_name": "NMEA datagram"}, | ||
) | ||
}, | ||
coords={ | ||
"time1": ( | ||
["time1"], | ||
"nmea_time": ( | ||
["nmea_time"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about time_nmea
to be consistent with the noun-modifier pattern that's used elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh just saw that there's ping_time
that deviates from this pattern, and it would be odd to make it time_ping
. Personally I feel it is cleaner for the other ones to be all like time_X
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh huh I never thought about it that way. I personally see them both as a standalone/compound noun since 'ping' + 'time' refer to different things but together form this one distinct thing and 'ping time' could be operated on like "short + 'ping time'", and 'nmea time' I feel could be operated on similarly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean, so ping time is when a ping is issues, and nmea is when an nmea sentence is issues. I agree with that. Perhaps we can just keep it this way here. We will at some point need a larger breaking change to keep up with convention changes once more feedback from the community is discussed, but that'll be at least a few months down the road.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctuguinay : Thanks for the investigation and fixes! I think this is ready to be merged once the time name is settled. My comment about __get_dataset
is probably better addressed separately, if needed.
Still in draft.
Resolves #1405, #1408, #1418.
Following the DataTree Migration Guide detailed here: https://github.com/pydata/xarray/blob/main/DATATREE_MIGRATION_GUIDE.md.