Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Use the jsoncpp submodule included in VRPN. #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CrossVR
Copy link
Collaborator

@CrossVR CrossVR commented Sep 1, 2015

We've already checked out this submodule, so why not use it?

Depends on vrpn/vrpn#109.

@CrossVR
Copy link
Collaborator Author

CrossVR commented Sep 13, 2015

I noticed this PR currently only works when building the server, but not when you're only building the client. I'll have a closer look at it next week.

@CrossVR
Copy link
Collaborator Author

CrossVR commented Sep 19, 2015

@rpavlik This PR works correctly now, but it depends on vrpn/vrpn#109.

@CrossVR CrossVR changed the title CMakeLists: Use the jsoncpp submodule as part of VRPN. CMakeLists: Use the jsoncpp submodule included in VRPN. Sep 19, 2015
@rpavlik
Copy link
Member

rpavlik commented Nov 12, 2015

I'd feel better just having the build done locally, inside OSVR's build system, but using the submodule, if the version in the submodule is sufficient - I haven't compared that version against the one I typically use recently. Doing so in the simplest way possible would leave some consumers of a pre-compiled library high and dry (or at least in need of building jsoncpp on their own), but there's no reason we couldn't support an external jsoncpp with the internal as fallback - the Linux distros whose packaging rules I'm familiar with would require this anyway (Debian really does not like vendored-in versions of libraries, and jsoncpp is widely used and widely packaged - and we're not terribly picky about the version we use).

@CrossVR
Copy link
Collaborator Author

CrossVR commented Nov 20, 2015

I'd feel better just having the build done locally, inside OSVR's build system, but using the submodule

Would a PR that implements that be acceptable?

Also, currently we depend on HID API being compiled in VRPN, the only reason I had to make jsoncpp a separate project is because it isn't compiled with VRPN if we're just building the client. So should the same be done for HID API at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants