Fixes case where node ip contains another PodIP #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a case where a follower won't get added because the PodIP is contained within another node ip, for example PodIP 172.17.0.2 and node 172.17.0.24:6379@16379 Signed-off-by: Andrew Thompson <andrew.thompson@crowdstrike.com>
devkmsg
added a commit
to devkmsg/redis-operator
that referenced
this pull request
Jan 30, 2024
Merge in OSS/redis-operator from master to cs-main * commit '1f0be5c52f4be026c5fe702fdde37e8b19ab307a': Bump terser from 4.8.0 to 4.8.1 in /docs (OT-CONTAINER-KIT#311) Add pvc, pv clusterrole for deletion (OT-CONTAINER-KIT#313) Update zap options to support specifying log level (OT-CONTAINER-KIT#308) [BugFix][Change] Fixed cluster recovery logic (OT-CONTAINER-KIT#304) [BugFix][Change] Fixed the logic for probes (OT-CONTAINER-KIT#302) Fixed pdb creation issue (OT-CONTAINER-KIT#301) [BugFix][Change] Fixed secret whitespace issue in redis password (OT-CONTAINER-KIT#300) fix: crash if targetContainer does not exist (OT-CONTAINER-KIT#292) fix: crash if redisSecret is incomplete (OT-CONTAINER-KIT#293) fix: panic if resources is not present (OT-CONTAINER-KIT#294) add: error log when a user tries to modify cr.spec.storage.volumeClaimTemplate (OT-CONTAINER-KIT#280) Fixes case where node ip contains another PodIP (OT-CONTAINER-KIT#284) Bump eventsource from 1.1.0 to 1.1.1 in /docs (OT-CONTAINER-KIT#282) Fixed rbac policy for PDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where a follower won't get added because the PodIP is
contained within another node ip, for example PodIP 172.17.0.2 and node 172.17.0.24:6379@16379
Signed-off-by: Andrew Thompson andrew.thompson@crowdstrike.com