Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid memory address or nil pointer dereference #395

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix: invalid memory address or nil pointer dereference #395

merged 1 commit into from
Dec 19, 2022

Conversation

lvyanru8200
Copy link
Contributor

Fixes: #394,#383
Signed-off-by: lvyanru yanru.lv@daocloud.io

Description

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@lvyanru8200
Copy link
Contributor Author

/cc @iamabhishek-dubey

@lvyanru8200
Copy link
Contributor Author

@iamabhishek-dubey ping

This was referenced Dec 12, 2022
Closed
Closed
@m-yosefpor
Copy link

any updates? @iamabhishek-dubey

this is a sever bug which affected us.

@iamabhishek-dubey iamabhishek-dubey linked an issue Dec 19, 2022 that may be closed by this pull request
upgrade operator error #383
Closed
@iamabhishek-dubey iamabhishek-dubey merged commit 3202785 into OT-CONTAINER-KIT:master Dec 19, 2022
devkmsg added a commit to devkmsg/redis-operator that referenced this pull request Mar 7, 2023
@devkmsg
Merge pull request OT-CONTAINER-KIT#11 in OSS/redis-operator from ~AT…
4a664bd 
…HOMPSON/redis-operator:sync-upstream-0.14 to master

Auto-Merge: Pull request OT-CONTAINER-KIT#11: [AUTO] Sync upstream @ v0.14

Merge in OSS/redis-operator from ~ATHOMPSON/redis-operatorsync-upstream-0.14 to master

* commit 'e86884ead1005484bdb10fb30caf8f8acac2f89b': (49 commits)
  [Feature] Add Redis Sentinel Support  (OT-CONTAINER-KIT#408)
  Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424)
  [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417)
  [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411)
  Fixes issue with arm64 support. (OT-CONTAINER-KIT#404)
  [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410)
  Add Label Selector to pod anti affinity  (OT-CONTAINER-KIT#407)
  When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398)
  fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395)
  export redis exporter as a container port (OT-CONTAINER-KIT#393)
  [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389)
  fix crash with go panic (OT-CONTAINER-KIT#385)
  Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380)
  [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376)
  [Development][Update]Updated information for v0.13.0 (OT-CONTAINER-KIT#374)
  Create CODE_OF_CONDUCT.md
  [feature]add tls for redis-standlone (OT-CONTAINER-KIT#372)
  Update README.md
  Create package.json
  Revamped documentation for better knowledge base (OT-CONTAINER-KIT#370)
  ...
devkmsg added a commit to devkmsg/redis-operator that referenced this pull request Jan 30, 2024
@devkmsg
Pull request OT-CONTAINER-KIT#12: Sync our internal branch to v0.14 w…
8b233c9 
…/internal patches

Merge in OSS/redis-operator from ~ATHOMPSON/redis-operator:sync-internal-cs-main-to-0.14 to cs-main

* commit '2ea8fcaf61b322186f8a0a2c4e7bcb310f55ea2d':
  Revert "Handle nil probe"
  Handle nil probe
  Bumps prometheus/client_golang to address vuln
  Adds CODEOWNERS for our internal branch
  [Feature] Add Redis Sentinel Support  (OT-CONTAINER-KIT#408)
  Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424)
  [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417)
  [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411)
  Fixes issue with arm64 support. (OT-CONTAINER-KIT#404)
  [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410)
  Add Label Selector to pod anti affinity  (OT-CONTAINER-KIT#407)
  When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398)
  fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395)
  export redis exporter as a container port (OT-CONTAINER-KIT#393)
  [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389)
  fix crash with go panic (OT-CONTAINER-KIT#385)
  Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380)
  [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamabhishek-dubey iamabhishek-dubey iamabhishek-dubey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic upgrade operator error
3 participants
@lvyanru8200 @m-yosefpor @iamabhishek-dubey