Skip to content

Commit

Permalink
Retooling overall build with hugely improved site page (#11)
Browse files Browse the repository at this point in the history
* [pom] Add xml tag with UTF-8 encoding

* [pom] Correct maven xsd location

* [pom] Remove prerequisites as its valid only for plugins

If there is a need to force maven version on build, use enforcer plugin per maven requirements.  Maven 3.5.0+ will warn with prerequisites being used.

* [pom] Update nexus-staging-maven-plugin to 1.6.8

* [pom] Update maven source plugin to 3.0.1

* [pom] Update maven javadoc plugin to 2.10.4

* [pom] Update jacoco maven plugin to 0.7.9

* [pom] Use ${project.basedir}

* [pom] Properly configure java version

* [pom] Fix jsr305 so it stays with single version

This was causing unnecessary problems by blindly allowing any version then continually looking for new on builds.  This is never a good idea to use this maven feature.

* [pom] Switch findbugs to spotbugs

Findbugs project is currently stuck.  Spotbugs is the current replacement with hopes findbugs will come back to life.  As such, I am currently supporting spotbugs maven plugin as the same situation exists for the findbugs maven plugin.  Same deal, hopes of making it back to the old one at some point.  This however continues off earlier findbugs in both cases and adds additional support.

* [pom] Finish off encoding proper maven 3 way

* [lib] Delete the entire thing, not very git like nor required

* [javadoc] JDK 8 is not spammy unless badly written, fixed only bad javadoc

* [git] Add Full Eclipse/Intellij/Sonar files to ignore and drop ANT bin

* [eclipse] Drop project files as unnecessary in any modern eclipse (m2e)

While this will affect current users simply delete project from eclipse,
delete remaining traces of ecipse from project, then reimport it.  m2e
will properly import the project.

* [pom] Raise to require java 6

Because the following code with Override Annotation is already requiring
java 6.

from EvalMinifier

@OverRide
public int compareTo(Token t) {

* [git] Add default gitattributes

* [ci] Cleanup RELEASE-checklist as command is 'mvn' not 'mvn3'

* [ci] Remove unnecessary eclipse suppress warnings

These are only issues if checks are turned on and if those checks are
turned on the project owner would likely be wanting to fix the issues.
So this generally is a bad idea to introduce and specific to an IDE.

* [site] Overhaul site with fluido

* [pom] Add support for running against sonarqube

Sonarqube 6.4 tested.  There are 2 bugs and 51 code smells at this
revision against this codebase that should be eventually looked at.
  • Loading branch information
hazendaz authored and mikesamuel committed Jul 11, 2017
1 parent b6810f2 commit b5e56f3
Show file tree
Hide file tree
Showing 21 changed files with 100 additions and 872 deletions.
9 changes: 0 additions & 9 deletions .classpath

This file was deleted.

17 changes: 17 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Auto detect text files and perform LF normalization
* text=auto

# Custom for Visual Studio
*.cs diff=csharp

# Standard to msysgit
*.doc diff=astextplain
*.DOC diff=astextplain
*.docx diff=astextplain
*.DOCX diff=astextplain
*.dot diff=astextplain
*.DOT diff=astextplain
*.pdf diff=astextplain
*.PDF diff=astextplain
*.rtf diff=astextplain
*.RTF diff=astextplain
13 changes: 12 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,13 @@
# Eclipse
.classpath
.settings
.project
.tern-project
target
bin

# Intellij
.idea
.iml

# sonarqube
.sonar_lock
17 changes: 0 additions & 17 deletions .project

This file was deleted.

8 changes: 4 additions & 4 deletions RELEASE-checklist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
and make sure that the current POM release number is max.

7. Check that it builds clean and the reports are ok.
$ mvn3 clean release:clean package site
$ mvn clean release:clean package site
Browse to file://$PWD/target/site and check the findbugs and jacoco reports.

8. Prepare a release which will check that the release plugin can
do its job and sanity check by running unit-tests.
$ mvn3 release:prepare
$ mvn release:prepare

9. Perform the release which creates a commit in github for the release
and updates master to the new development snapshot version.
$ mvn3 release:perform
$ mvn release:perform

10. Checkout the release branch being sure to use the appropriate release
version tag.
Expand All @@ -36,7 +36,7 @@
$ cd json-sanitizer-release

11. Deploy to nexus
$ mvn3 deploy
$ mvn deploy

12. Log in to https://oss.sonatype.org/ then close and release.
a. Click "Staging Repositories" in the left hand bar.
Expand Down
11 changes: 0 additions & 11 deletions lib/jsr305/COPYING

This file was deleted.

Binary file removed lib/jsr305/jsr305.jar
Binary file not shown.
Loading

0 comments on commit b5e56f3

Please sign in to comment.