Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Python scripts using Black #1200

Closed
za opened this issue Jan 25, 2024 · 3 comments · Fixed by #1202
Closed

Format Python scripts using Black #1200

za opened this issue Jan 25, 2024 · 3 comments · Fixed by #1202
Assignees

Comments

@za
Copy link
Contributor

za commented Jan 25, 2024

Hi there,

What if we format the Python scripts scripts/sort_contibutors/main.py using Black? The goal of formatting is to increase readability of the code (as we follow the standardized format on writing the code).

If OK, I'll create a PR for this. So far, I only found one Python script on this repo.

@commjoen
Copy link
Collaborator

Hi @za ,
I am fine if you format imports/code, but can you please add any formatter to the pre-commit hooks? Note: the pre-commit hooks need to run on windows/linux and primarily on MacOS.

@za
Copy link
Contributor Author

za commented Jan 25, 2024

OK, will have a look on the pre-commit part @commjoen

za added a commit to za/wrongsecrets that referenced this issue Jan 26, 2024
So the style is consistent
Refer to issue: OWASP#1200
@za
Copy link
Contributor Author

za commented Jan 29, 2024

Thanks for the review @commjoen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants