Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace depreciated Asciidoctor::convert() used in AsciiDocGenerator #525

Closed
drnow4u opened this issue Dec 1, 2022 · 2 comments · Fixed by #528
Closed

Replace depreciated Asciidoctor::convert() used in AsciiDocGenerator #525

drnow4u opened this issue Dec 1, 2022 · 2 comments · Fixed by #528
Assignees
@nhumblot

Comments

@drnow4u
Copy link
Collaborator

drnow4u commented Dec 1, 2022 •
edited
Loading

As a developer I want not to use new recommended API instead of old depreciated API for Asciidoctor::convert() and OptionsBuilder::options() from org.asciidoctor 2.5.7 package.

Acceptance criteria:

  • All use of Asciidoctor::convert() is replaced with recommended bean configuration
  • All use of OptionsBuilder::options() is replaced with recommended bean configuration.
@nhumblot
Copy link
Contributor

nhumblot commented Dec 2, 2022

Hi 👋

I started to work on this one, is it possible to assign it to me? Thank you! 🙂

nhumblot added a commit to nhumblot/wrongsecrets that referenced this issue Dec 2, 2022
@nhumblot
OWASP#525 Replace Asciidoctor::convert() and OptionsBuilder::options(…
dfdef65 
…) deprecated methods
@nhumblot nhumblot mentioned this issue Dec 2, 2022
Merged
@commjoen
Copy link
Collaborator

commjoen commented Dec 2, 2022 •
edited
Loading

Thank you for picking it up! The floor is yours good sir!

commjoen added a commit that referenced this issue Dec 3, 2022
@commjoen
Merge pull request #528 from nhumblot/525-replace-deprecated-asciidoc…
fc7e4ec 
…tor-and-options-builder-methods

#525 Replace Asciidoctor::convert() and OptionsBuilder::options() dep…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhumblot nhumblot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#525 Replace Asciidoctor::convert() and OptionsBuilder::options() dep… nhumblot/wrongsecrets
3 participants
@commjoen @drnow4u @nhumblot