Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sealed Secret in Kubernetes #858

Closed
drnow4u opened this issue Jun 3, 2023 · 14 comments
Closed

Sealed Secret in Kubernetes #858

drnow4u opened this issue Jun 3, 2023 · 14 comments
Assignees
Labels
help wanted Extra attention is needed New Challenge Adding a new Challenge

Comments

@drnow4u
Copy link
Collaborator

drnow4u commented Jun 3, 2023

In the repository would be committed file containing Sealed Secret e.g.:

apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  name: mysecret
  namespace: mynamespace
spec:
  encryptedData:
    foo: AgBy3i4OJSWK+PiTySYZZA9rO43cGDEq.....

Sealed Secret is asymmetrically encrypted and only the Sealed Secret Controller deployed in Kubernetes can decrypt it. Such decrypted secrets "unsealed" are stored as classic Kubernetes secret.

apiVersion: v1
kind: Secret
metadata:
  name: mysecret
  namespace: mynamespace
data:
  foo: YmFy  # <- base64 encoded "bar"

@commjoen could you describe proposed on Slack attack vector?

@drnow4u drnow4u added the New Challenge Adding a new Challenge label Jun 3, 2023
@commjoen
Copy link
Collaborator

commjoen commented Jun 3, 2023

We would get into trouble if the private key is somehow compromised: either by specifying a backup key to use teh secret without the controler or by having the secret accessible due to an RBAC misconfiguration. However: i have not seen any of the 2 cases alive yet. @bendehaan : what should we do here?

@commjoen
Copy link
Collaborator

commjoen commented Jun 3, 2023

One of the challenges would still be: how can we implement this in ctf-party? should the controler live in a namespace everyone has access to?

@commjoen
Copy link
Collaborator

commjoen commented Jun 4, 2023

As agreed with @bendehaan :We can implement it for now using a controller with an exposed private key. Assigning this one to you @MarcinNowak-codes

@commjoen commjoen added the help wanted Extra attention is needed label Aug 18, 2023
@commjoen
Copy link
Collaborator

commjoen commented Oct 4, 2023

@bendehaan is this still something you want to pick up :) ?

@bendehaan
Copy link
Collaborator

@commjoen I can't recall I was assignee earlier, shouldn't it be @drnow4u?

@commjoen
Copy link
Collaborator

commjoen commented Oct 4, 2023

Anyone want to pick this one up :) ?

@Shubham-Patel07
Copy link
Contributor

i want to work on this issue :-) @commjoen

@Shubham-Patel07
Copy link
Contributor

Shubham-Patel07 commented Jan 26, 2024

@commjoen has some discussion already done on slack about this issue ??
i wanted some more details on this

@commjoen
Copy link
Collaborator

Yes. Please check with @bendehaan on Slack.

@commjoen
Copy link
Collaborator

@Shubham-Patel07 can you, before taking on this issue, first fix the other 2 outstanding PRs please?

@Shubham-Patel07
Copy link
Contributor

I've fixed the outstanding issue now i wanted to give it a try !!

@commjoen
Copy link
Collaborator

commjoen commented Jul 7, 2024

Missing unit tests and textual corrections. Good to know: @Shubham-Patel07 given current RBAC, we could add the hints of accessing the secret directly, meaning all can be done in the same challenge ;-)

@commjoen
Copy link
Collaborator

commjoen commented Jul 8, 2024

Updated #1521 to have both cahllenges combined in this one.

@commjoen
Copy link
Collaborator

commjoen commented Jul 8, 2024

Done with #1521

@commjoen commjoen closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed New Challenge Adding a new Challenge
Projects
Status: Done
Development

No branches or pull requests

4 participants