Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update challenge48 to have both solutions in 1 #1521

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Update challenge48 to have both solutions in 1 #1521

merged 5 commits into from
Jul 8, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Jul 8, 2024 •
edited
Loading

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation: update challenge48 and the readme
  • Something else

Description

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner July 8, 2024 04:33
@commjoen commjoen mentioned this pull request Jul 8, 2024
Closed
@commjoen commjoen changed the title Updatechallenge48 Update challenge48 to have both solutions in 1 Jul 8, 2024
bendehaan
bendehaan reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some clarification on sealed secrets

src/main/resources/explanations/challenge48_reason.adoc Outdated Show resolved Hide resolved
@commjoen @bendehaan
Apply suggestions from code review
b9e567c 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@commjoen commjoen merged commit f35c76b into master Jul 8, 2024
15 checks passed
@commjoen commjoen deleted the updatechallenge48 branch July 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan bendehaan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commjoen @bendehaan