-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributor rankings #1022
Contributor rankings #1022
Conversation
Until now, the code performs the following:
I'd like to be cleared about add "Special thanks" and "tester" listing as hardcoded part of the script . To execute the script you must create the .env file and store your github token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roddas this is a great starting point!
What i am basically looking for, is a script that can generate the listing at https://github.com/OWASP/wrongsecrets/blob/master/README.md#special-thanks--contributors and https://github.com/OWASP/wrongsecrets/blob/master/src/main/resources/templates/welcome.html#L104-L150 automatically based on the statistics you already have of the 3 repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roddas ,
i tested teh script and it looks promising! Not sure if it takes the full history of every repo for some reason, as some stats are still relatively low.
Can we maybe have a filter for folks that are only present at wrongsecrets-ctf-party :) ?
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
update the print_html
scripts/sort_contibutors/main.py
Outdated
print("[+] Fetching the Wrong Secrets contributors list ... ") | ||
wrongsecrets_list = fetch_repository('wrongsecrets', token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for fetching it twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'll fix it now .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed.
One more thing: |
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful! Thank you for your hard work @roddas ! You rock!
What kind of changes does this PR include?
Description
Relations
Closes #984
References
Checklist: