Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alternative text in the pictures to the contribution file #1066

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

CaduRoriz
Copy link
Contributor

  • Fixes or refactors
  • A new challenge
  • [ x ] Additional documentation
  • Something else

Description

Alternative text has been added to the images in the contribution document.

Relations

Relates #1049

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • [x ] I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CaduRoriz ! Looks great! Can you extend the logging picture its alt text please? We need at least the profile and the last sentence indicating a successful boot.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!🙏

@commjoen commjoen merged commit d6e780e into OWASP:master Oct 31, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants