Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix gcp ingress #1138

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: fix gcp ingress #1138

merged 1 commit into from
Dec 12, 2023

Conversation

bendehaan
Copy link
Collaborator

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Fix an omission in the GCP ingress start script (challenge 33).

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen merged commit 0d7fe55 into master Dec 12, 2023
13 of 16 checks passed
@commjoen commjoen deleted the fix/gcp-ingress branch December 12, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen Awaiting requested review from commjoen commjoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendehaan @commjoen