Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run Cypress test against pre-compiled HTML #1141

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

nbaars
Copy link
Collaborator

@nbaars nbaars commented Dec 13, 2023

During the build html files are generated based on ascii doc files. When we run the Cypress test in a Maven build we should test against these html files for the challenge text etc. This way we make sure the asciidoc plugin in Maven works.

The Cypress test running outside Maven still use the on-the-fly asciidoc generator. This way one can still directly see the changes in the challenge text when running the Cypress tests directly.

Closes: gh-1139

During the build html files are generated based on ascii doc files. When we run the Cypress test in a Maven build we should test against these html files for the challenge text etc. This way we make sure the asciidoc plugin in Maven works.

The Cypress test running outside Maven still use the on-the-fly asciidoc generator. This way one can still directly see the changes in the challenge text when running the Cypress tests directly.
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nbaars ! this will greatly help detection possible issues with the compilation!

@commjoen commjoen merged commit a1158f4 into master Dec 14, 2023
15 checks passed
@commjoen commjoen deleted the nbaars/1139 branch December 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Cypress tests with PreCompiledGenerator to make sure the asciidoc is generated
2 participants