Challenge 43: new challenge for secret shared on social media.

[djvinnie]

What kind of changes does this PR include?

• Fixes or refactors
• A new challenge
• Additional documentation
• Something else

Description

Added new challenge according to documentation.

Relations

Relates #616

References

Checklist:

• All the contributions made are solely the work of me and my co-authors
• I tested the changes in this PR (if applicable)
• I added unit tests to ensure my change works (when change in Java or on front-end code)
• I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
• The PR passes pre-commit hooks and automated tests

[commjoen]

Hi @djvinnie ! Awesome to see your first challenge!
Sorry to make it a liiitle bit harder to finish it as, looking at the challenge in its first complete version, the link to the microsoft golden key blunder feels a bit weak.. @bendehaan what do you think of the alternative text?

[commjoen]

can we, instead of giving a hint about the secret, just say the following please?:

Suggested change

	private final String secretKey = new String(Hex.decode("4348524953544D4153324B3233"));
	@Test
	void spoilerShouldRevealAnswer() {
	var challenge = new Challenge43();
	assertThat(challenge.spoiler()).isEqualTo(new Spoiler(secretKey));
	}
	@Test
	void rightAnswerShouldSolveChallenge() {
	var challenge = new Challenge43();
	assertThat(challenge.answerCorrect(secretKey)).isTrue();
	}
	@Test
	void rightAnswerShouldSolveChallenge() {
	var challenge = new Challenge43();
	assertThat(challenge.answerCorrect(challenge.spoiler())).isTrue();
	}

[djvinnie]

Thanks for your comments @commjoen ! I will wait to hear Ben's comments before making the changes you have proposed :)

[commjoen]

Thank you @djvinnie ! LGTM!