-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1193: update trufflehog command on the challenge 1 hint doc #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because with previous command it's not showing the result. Trufflehog needs to scan the filesystem and use generic detector from the example. Note: it's suggested to use the latest Trufflehog version. When this commit was made, the latest version is: 3.63.10
…ttern we need to download the generic detector provided by trufflehog https://github.com/trufflesecurity/trufflehog/tree/4afc224c635d10e732119f715f93788af1502ce4/examples#generic-detector
commjoen
reviewed
Jan 22, 2024
commjoen
reviewed
Jan 22, 2024
as suggested by commjoen Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Added trufflehog version 2 which can be installed using pip. Note: trufflehog version 2 was released > 5 years ago and no longer maintaned. Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
So the reader aware of the trufflehog version 2 situation.
commjoen
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @za !
Thanks for merging it @commjoen ! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
because with previous command it's not showing the result. Trufflehog needs to scan the filesystem and use generic detector from the example.
Note: it's suggested to use the latest Trufflehog version. When this
commit was made, the latest version is: 3.63.10
Relations
Closes #1193
References
Checklist: