Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 613 secret gitignore ssh #1230

Closed
wants to merge 2 commits into from

Conversation

za
Copy link
Contributor

@za za commented Feb 1, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Added new secrets on .gitignore and .ssh

Relations

#613

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@za za requested review from commjoen and bendehaan as code owners February 1, 2024 04:09
@commjoen
Copy link
Collaborator

commjoen commented Feb 1, 2024

CoC warning: please don't "steal" other peoples issues unless you are sure that you can take over that issue.

@commjoen commjoen closed this Feb 1, 2024
@za
Copy link
Contributor Author

za commented Feb 1, 2024

CoC warning: please don't "steal" other peoples issues unless you are sure that you can take over that issue.

Noted @commjoen 📝

@commjoen
Copy link
Collaborator

commjoen commented Feb 1, 2024

All good @za , I understand you had good intentions :). The problem often with many of the "good first issues" is that the people who get it assigned need help and time to finish it :) .

@commjoen
Copy link
Collaborator

commjoen commented Feb 1, 2024

@za
Copy link
Contributor Author

za commented Feb 1, 2024

All good @za , I understand you had good intentions :). The problem often with many of the "good first issues" is that the people who get it assigned need help and time to finish it :) .

No worries @commjoen

I have no intention to take over/steal/coup d etat someone else's issue 😎. It's just because idle and I don't see any progress yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants