Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add documentation on TLS for AWS and GCP #1407

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented May 21, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Add a short line in documentation on how to set up TLS.

Relations

Closes #252, #149

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@bendehaan bendehaan requested a review from commjoen as a code owner May 21, 2024 09:05
@commjoen commjoen merged commit 8d151d8 into master May 21, 2024
15 of 17 checks passed
@commjoen commjoen deleted the fix/cloud-tls-readme branch May 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document on how to Add TLS certificate on load-balancer for GCP
2 participants