Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change healthcheck path #1409

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: change healthcheck path #1409

merged 1 commit into from
May 21, 2024

Conversation

bendehaan
Copy link
Collaborator

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Fix the AWS LB health check path to prevent hogging resources for sessions.

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@bendehaan bendehaan requested a review from commjoen as a code owner May 21, 2024 11:03
@commjoen
Copy link
Collaborator

Now i wonder: do we have to do the same for GCP/Azure :D ? (at lest in apprun you might have to :D )

@bendehaan bendehaan changed the title fix: change healthceck path fix: change healthcheck path May 21, 2024
@commjoen commjoen merged commit 283b0dd into master May 21, 2024
16 of 17 checks passed
@commjoen commjoen deleted the fix/healthcheck branch May 21, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants