Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issue templates for three categories #655

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented Feb 28, 2023

What kind of changes does this PR include?

Adds issue templates for: bug reports, feature requests and challenge requests/ideas

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@@ -1,15 +1,19 @@
Thank you for submitting a pull request to the WrongSecrets app!
Thank you for submitting a pull request to the WrongSecrets app! Please link any relevant issues.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe explain how to do that with an example? (e.g. #333 where 333 is your issue number)


- [ ] All the contributions made are solely the work of me and my co-authors
- [ ] I tested the changes in this PR (if applicable)
- [ ] I added unit tests to ensure my change works (when change in Java or on front-end code)
- [ ] The PR passes pre-commit hooks and automated tests

### Please provide some more information about your PR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace this with "please provide a link to the issue if available".

fix: add to PR template

fix: rephrase to challenge idea

fix: consistenly use h3

fix: refactor PR template
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! some of it might be a bit lengthy, but let's see if it works out :)

@commjoen commjoen merged commit a9bfbff into master Mar 1, 2023
@commjoen commjoen deleted the feat/issue-template branch March 1, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants