-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Challenge 28 #690
Adding Challenge 28 #690
Conversation
@commjoen @bendehaan |
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @puneeth072003 ! Your first challenge! thank you!
Here are some feedback items based on the textual and linting results. You can, for each suggestion click on "commit suggestion" or "add suggestion to batch"in the files overview, and then quickly add the recommended changes.
After that, let's file the issue :D !
Love this!
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge28.java
Outdated
Show resolved
Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge28Test.java
Outdated
Show resolved
Hide resolved
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28Test.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
…ge28.java Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thank you @puneeth072003 !
@bendehaan would you be able to do one more round of textual reviewing on it please?
What kind of changes does this PR include?
Description
Adding a new challenge 28 as asked in issue #423 completing the Part 1 of that issue
Relations
issue #423
Checklist: