-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 11-Testing_for_Simultaneous_Sessions #1111
Conversation
I'd suggest adding this to 01 or 08. |
I can work on it, but I think we should care about how big 01 section must be. Also, section 08 might not be the best place to include this information. |
Okay, I'll wait for a few others to chime in with their thoughts. |
Should I tag someone? |
Nope, just give it a few days, they should get GitHub notifications. If they don't add their thoughts I'll hit them up out of band. |
I think that this would make more sense in its own section - it could be squeezed into 01 or 08, but doesn't really seem to fit too well there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, and it's a useful check to add. I'm always a bit twitchy about this issue though, because it's something that can often be indiscriminately reported regardless of whether it's actually a security issue in the context of the application - so I think some guidance around that might be useful.
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
...lication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Simultaneous_Sessions
Outdated
Show resolved
Hide resolved
…ent_Sessions Fix title
Change summary part
Fixed response sample and added some notes for improved testing.
@0xmaximus can you please have the file extension? As for the file location, I'm okay with this being its own file. Thank you for taking care of this PR! |
It will need to be linked appropriately in the section index and overall. |
…t_Sessions.md Add .md extention
This comment has been minimized.
This comment has been minimized.
improve the summary part and add some essential factors
This comment has been minimized.
This comment has been minimized.
Add more test cases for "How to test" and "Remediation" part.
This comment has been minimized.
This comment has been minimized.
Fix blank problems
This comment has been minimized.
This comment has been minimized.
removed "distant" word.
This comment has been minimized.
This comment has been minimized.
Fix comment part
This comment has been minimized.
This comment has been minimized.
Fixed lint check.
Removed repeated words.
Removed repeated words.
Removed capital alphabet.
I would appreciate it if any other potential issues are mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to be linked in the various indexes.
...ication_Security_Testing/06-Session_Management_Testing/11-Testing_for_Concurrent_Sessions.md
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
If I understand you correctly, I should modify these files and add new link: |
…ent_Testing/11-Testing_for_Concurrent_Sessions.md Co-authored-by: Rick M <kingthorin@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Don't worry about the checklists they're generated. There should be 3 READMEs. This PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close
This PR fixes #1110.
What did this PR accomplish?
Adding "Test for Simultaneous sessions" in Session Management Testing.