fixed some missing lang entries #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ivoba
changed the title
|
@Sieg can you have look here, should be an easy pick |
Sieg
reviewed
Mar 21, 2018
| @@ -157,6 +157,7 @@ | |||
| 'SHOP_THEME_sBackgroundPosHorizontal_right' => 'rechts', | |||
| 'SHOP_THEME_sBackgroundPosHorizontal_center' => 'zentriert', | |||
| 'SHOP_THEME_sBackgroundPosVertical' => 'Vertikale Position des Hintergrundbildes', | |||
| 'SHOP_THEME_sBackgroundPosVertical_left' => 'links', | |||
There was a problem hiding this comment.
Vertical left? Something is wrong here :)
Sieg
pushed a commit
that referenced
this pull request
Mar 21, 2018
Sieg
pushed a commit
that referenced
this pull request
Mar 21, 2018
Use CLICK_HERE in place of currently used missing one. Related #117
|
Hello @ivoba, I have squashed your commits to be more grouped, and added a line to changelog. I have skipped the last commit regarding the SHOP_THEME_sBackgroundPosVertical_left, as i cannot see any problems regarding this value. We have Horizontal_left key there, anything i have missed? Please write more description how to reproduce the problem if there is one. |
Sieg
added
Bug
Enhancement
Ready to merge
in progress
and removed
in progress
Bug
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fresh install of OXID6 with flow theme i noticed this error:
In the shop there is only CLOSE so this ident is missing.
Replaced missing ADD_RECOMM_ADDRECOMMLINK2 with CLICK_HERE as in azure theme.
Further missing SHOP_THEME_sBackgroundPosVertical_left was added.