Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the "more" link in the main menu #50

Closed
wants to merge 6 commits into from

Conversation

martin-hofer
Copy link
Contributor

The "moreLinks" element in the main navigation is all kinds of broken. Here's a fix for that.

  • Added the necessary class names (and removed the wrong ones) to several elements, removed the empty caret, removed the ::after-caret and replaced it with fa-angle-down. Now the menu looks and behaves like a normal submenu.
  • Added CSS so "moreLinks" now has an arrowhead cursor instead of the text cursor.
  • Added internationalization: Up until now, the link was always German "Mehr", no matter what language was active.

@martin-hofer
Copy link
Contributor Author

martin-hofer commented Jul 22, 2019

PS: Added a fix for the problem that sometimes there were too many items in the sticky navigation to leave room for the cart and search icons, causing the moreLink item to appear below the navigation.

Sieg pushed a commit that referenced this pull request Aug 1, 2019
* fixed classes
* gave it an arrow cursor instead of the text cursor

Related #50
Sieg pushed a commit that referenced this pull request Aug 1, 2019
Sieg pushed a commit that referenced this pull request Aug 1, 2019
Sieg pushed a commit that referenced this pull request Aug 1, 2019
Sieg added a commit that referenced this pull request Aug 1, 2019
@Sieg
Copy link
Member

Sieg commented Aug 1, 2019

Hello @martin-hofer! Thanks for the fix! Great job with that button!

@Sieg Sieg closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants