keys removed in DE but haven't been removed in EN #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sieg
pushed a commit
that referenced
this pull request
Jul 23, 2019
|
Hello @kermie, I have merged your PR to the master of Wave, and ported to Flow, but looks like it is not the end of the question. There are much more outdated econda keys around those configurations. Will add this to our grooming to created analyzing and cleanup story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the lang keys 'HELP_SHOP_THEME_sEcondaAccountId' and 'SHOP_THEME_sEcondaAccountId' have been removed in https://github.com/OXID-eSales/wave-theme/blob/master/en/theme_options.php#L194 and #L195 from DE lang file but never from EN lang file. Actually the same goes for Flow Theme. This PR shall resolve it.