Added !default to the settings in _variables.scss #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Wave 1.2.0
Wave-Update
Sieg
pushed a commit
that referenced
this pull request
Aug 1, 2019
|
Hello @martin-hofer! Thanks for the improvement! Looks great, have just merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose that the settings in _variables.scss should have the !default flag set.
With this flag, it becomes so much easier to derive child templates while using Wave's original files. Creating a red theme is then as easy as this:
$brand-primary: #c00; @import '../../../wave/build/scss/variables'; ...Without the default flag, this doesn't work, because Wave's _variables.scss overwrites these previously set variables again. Simply redefining $brand-primary after the import of _variables.scss doesn't help either, because other variables inside _variables.scss will by then already have inherited these values (e.g. $link-hover-color: $brand-primary;).
This is probably the reason why bootstrap itself is doing it this way, too:
https://github.com/twbs/bootstrap/blob/master/scss/_variables.scss