added a nav bar and fixed some spacing issues. Sticky position was no… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t working the way I intended though so if this was configured to work on mobile before you may want to test it again now.
|
Looks good! It seems like this works fine, it's just that it's no longer sticky. I don't think the stickiness matters a whole lot compared to the changes you've made here, so I'll merge this. We can always make it sticky later. In the future, it might be good for us to make it work for slightly smaller screens, but those probably aren't too common anymore, so it's not a high priority. (For example, it doesn't look great at 320x568, which is the size of an iPhone 5 or a 1st-gen iPhone SE.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t working the way I intended though so if this was configured to work on mobile before you may want to test it again now.