You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been changes to the deneb spec recently(see PR).
We need to update our code to comply with the updated deneb specs.
🛠️ Proposed solution
Note that in the updated spec, we don't require signatures on blob sidecars. Hence, the change to our core interfaces doesn't make sense anymore as we now have a single signature per signed object.
Revert PR#2635
In all eth2spec.DataVersionDeneb cases, use only the SignedBeaconBlock signature.
There may be changes on the go-eth2-client side
🧪 Tests
Tested by new automated unit/integration/smoke tests
Manually tested on core team/canary/test clusters
Manually tested on local compose simnet
The text was updated successfully, but these errors were encountered:
Revert changes to core interfaces.
This is done since the deneb upgrade no longer requires multiple signatures per signed object. Reverting to the original implementation makes the interfaces simple and code much easier to reason about.
category: refactor
ticket: #2659
🎯 Problem to be solved
There have been changes to the deneb spec recently(see PR).
We need to update our code to comply with the updated deneb specs.
🛠️ Proposed solution
Note that in the updated spec, we don't require signatures on blob sidecars. Hence, the change to our core interfaces doesn't make sense anymore as we now have a single signature per signed object.
eth2spec.DataVersionDeneb
cases, use only theSignedBeaconBlock
signature.🧪 Tests
The text was updated successfully, but these errors were encountered: