Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/validatorapi: propose v1 and v2 returns 404 #3167

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Jul 9, 2024

Endpoints produce_block and produce_blinded_block must return 404 explicitly to prevent processing as proxy calls. Because previously we removed these from the router.
Also, this ensures all attempts to call these endpoint will increment core_validatorapi_request_error_total counter.

category: feature
ticket: #1255

@pinebit pinebit requested review from gsora and KaloyanTanev July 9, 2024 10:47
Copy link

sonarqubecloud bot commented Jul 9, 2024

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.77%. Comparing base (82d6f70) to head (9a0f636).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
+ Coverage   56.65%   56.77%   +0.11%     
==========================================
  Files         208      208              
  Lines       29202    29221      +19     
==========================================
+ Hits        16545    16589      +44     
+ Misses      10828    10807      -21     
+ Partials     1829     1825       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 9, 2024
@obol-bulldozer obol-bulldozer bot merged commit 3b2f598 into main Jul 9, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/propose-v1-v2-returns-404 branch July 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants