Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: various fixes #3406

Closed
wants to merge 5 commits into from
Closed

*: various fixes #3406

wants to merge 5 commits into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 8, 2024

Overview

This pull request addresses several typographical and grammatical errors in various files, improving clarity and consistency across the repository. The changes focus on minor fixes such as correcting spelling, grammar, and phrasing in YAML configuration files and shell scripts.


Changes in this PR:

  1. Fixed typos and grammatical errors:
    • Replaced "Deply" with "Deploy" in workflow names.
    • Corrected "meta data" to "metadata" in several files for consistency.
    • Adjusted phrasing for better readability, e.g., "Short name for current branch" → "Short name for the current branch."
    • Fixed a typo in the shell script: "Chck" → "Check."
  2. Improved wording:
    • Enhanced instructions in the bug_report.md template for clearer communication.
    • Fixed minor gaps and inconsistencies in descriptions.

Files Updated:

  1. .github/ISSUE_TEMPLATE/bug_report.md:
    • Improved phrasing and fixed repetitive wording.
  2. .github/workflows/build-push-deploy-promrated.yaml:
    • Fixed workflow naming issues and metadata terminology.
  3. .github/workflows/build-push-deploy.yml:
    • Standardized terminology for metadata descriptions.
  4. .github/workflows/label-pr.yml:
    • Improved phrasing for comments in the workflow file.
  5. .pre-commit/run_testutil.sh:
    • Corrected a typo in a comment.

Testing:

  • No functional changes were introduced, so no new tests are required.
  • Verified the YAML files to ensure syntax correctness after changes.

category: docs
ticket: none

Copy link

sonarqubecloud bot commented Dec 8, 2024

@pinebit pinebit changed the title Fixer mixer *: various fixes Dec 11, 2024
@gsora
Copy link
Collaborator

gsora commented Dec 11, 2024

LFTM

@OisinKyne wanna give it a look before merging?

@pinebit
Copy link
Contributor

pinebit commented Dec 20, 2024

We have an ongoing internal effort fixing the same issues.

@pinebit pinebit closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants