core/consensus: fixed instance_io race #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 57.36% 57.36%
=======================================
Files 217 217
Lines 31977 31965 -12
=======================================
- Hits 18343 18338 -5
+ Misses 11743 11739 -4
+ Partials 1891 1888 -3 ☔ View full report in Codecov by Sentry. |
pinebit
added
the
merge when ready
gsora
reviewed
Dec 12, 2024
core/consensus/utils/instance_io.go
Outdated
| Participated chan struct{} // Closed when Participate was called for this instance. | ||
| Proposed chan struct{} // Closed when Propose was called for this instance. | ||
| Running chan struct{} // Closed when runInstance was already called. | ||
| Participated int32 // Closed when Participate was called for this instance. |
There was a problem hiding this comment.
We should change those comments, there are no channels involved in this anymore.
There was a problem hiding this comment.
Indeed, changed as suggested.
|
gsora
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed a bug in our consensus object
instance_iowhere we have the race condition:panic: close of closed channelFixed the race condition using atomic operations instead of channels.
category: bug
ticket: none