Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/peerinfo: add nickname field to peerinfo protocol #3428

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DiogoSantoss
Copy link

Add nickname flag to run command, exchange nicknames using peerinfo protocol and create nickname metric to display on Grafana.

Preview:
Screenshot from 2024-12-17 09-11-26

category: feature
ticket: #1655

@DiogoSantoss DiogoSantoss requested a review from pinebit December 17, 2024 09:57
@DiogoSantoss DiogoSantoss changed the title app/peerinfo: Add nickname field to peerinfo protocol app/peerinfo: add nickname field to peerinfo protocol Dec 17, 2024
@gsora
Copy link
Collaborator

gsora commented Dec 17, 2024

Do we need to handle the case in which two or more peer have the same nickname?

@DiogoSantoss
Copy link
Author

We probably should, just not sure what to do in that case. We could change our own by adding some suffix to the nickname. I don't know if we consider malicious nodes in this case.

cmd/run.go Outdated Show resolved Hide resolved
@pinebit
Copy link
Contributor

pinebit commented Dec 17, 2024

Do we need to handle the case in which two or more peer have the same nickname?

I think we can't do much about this.. just allow them to do that.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.37%. Comparing base (8981a5a) to head (6978a3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 6 Missing ⚠️
app/peerinfo/peerinfo.go 82.35% 3 Missing ⚠️
cmd/run.go 25.00% 2 Missing and 1 partial ⚠️
app/peerinfo/peerinfopb/v1/peerinfo.pb.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
+ Coverage   57.34%   57.37%   +0.03%     
==========================================
  Files         217      217              
  Lines       31965    31991      +26     
==========================================
+ Hits        18330    18356      +26     
- Misses      11744    11745       +1     
+ Partials     1891     1890       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants