-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app/peerinfo: add nickname field to peerinfo protocol #3428
base: main
Are you sure you want to change the base?
Conversation
Do we need to handle the case in which two or more peer have the same nickname? |
We probably should, just not sure what to do in that case. We could change our own by adding some suffix to the nickname. I don't know if we consider malicious nodes in this case. |
I think we can't do much about this.. just allow them to do that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
==========================================
+ Coverage 57.34% 57.37% +0.03%
==========================================
Files 217 217
Lines 31965 31991 +26
==========================================
+ Hits 18330 18356 +26
- Misses 11744 11745 +1
+ Partials 1891 1890 -1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Add nickname flag to
run
command, exchange nicknames using peerinfo protocol and create nickname metric to display on Grafana.Preview:
category: feature
ticket: #1655