-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the option to ignore files and folders via settings #289
Conversation
kindly update |
it looks like author is away since December 2020😥 |
@Pseudonium Is there any chance we could get this feature merged? There are conflicts that I'd be willing to look into resolving, but since this PR is so old I'd like to get some confirmation on whether it has a chance of being merged back? This feature to ignore files is very beneficial for:
If not, could you drop a comment as to why and close the PR as won't merge? |
Maybe we should think about a maintained fork. |
@MisterPresident I was thinking about that myself. One of the worst things about such impactful open-source projects like this, is they tend to succumb to Bus Factor one day. Many good obsidian plugins especially have. It's really important for project owners to find a few contributors to give write access to so the project can continue without you. But at least there is a LICENSE file. So separately maintained forks can be used for distribution. |
# Conflicts: # manifest.json
Can you rebase this PR and add some Tests ? Do take note of this feature (ShootingKing-AM#154) |
# Conflicts: # manifest.json # package-lock.json # package.json
Are you done @niposch ? Can you add some information about this feature and how to use in Readme.MD. Also since we already know that excalidraw, Templater obsidian addons can you set the default setting to ignore this file. It would be also awesome if you can do a hyperlink some example so that a common (non-developer) can understand how to use globs (dont specify .gitignore :) ). Also you can have some examples as placeholder text, like "ignore_this_file.md\nignore_this_dir/*" so that it will be easy for common users to understand. Let me know when you are done, want to merge this feature as soon as possible :) |
I'm done. Added a bit more documentation and a default value for the setting and a better placeholder. |
Seems like some tests are failing - https://github.com/Pseudonium/Obsidian_to_Anki/actions/runs/7627084329/job/20774950101?pr=503#step:7:9685 |
commit 867f230 Author: niposch <niposch@gmail.com> Date: Tue Jan 23 16:34:09 2024 +0100 fixed python tests
still you can find the failed tests here #503 |
I added a text field in the settings where globs can be put into.
If any of these match a file, it will be ignored and therefore not be scanned.
This feature is especially useful when using this plugin in combination with the obsidian-excalidraw-plugin because this plugin stores its files as .excalidraw.md.
This will cause the Obsidian_to_Anki plugin to scan these files. Excessive scan times are caused by scanning these large files.
Adding
**/*.excalidraw.md
to the ignore option will alleviate this problem because these files will be ignored.It could also be useful if a user wishes a specific folder not to be scanned (f.e. the template folder)
The option I added should behave like a git ignore file which is documented here: https://git-scm.com/docs/gitignore