-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Emma in the code reviewers. #156
Missing Emma in the code reviewers. #156
Conversation
@vturpin , is Thierry Carval still active? If not, should we remove him from the reviewers's list so he stops receiving automatic alerts from every change here? Note that this is just an internal GitHub setup and has nothing to do with the document itself. |
Hi,@castelao, I just check with Thierry, he was about to answer but I'll do it on his behalf. He is sorry not being able to be active here. He is obviously very interested, but has no time to dedicate. |
@vturpin , thanks! @tcarval , I'm sorry. I made a poor choice of words here, and in doing so I was quite rude. I remember hearing that someone retired over there and thought it could be you. What I actually wanted to ask was if you were interested in keep receiving this alerts. I believe that you should receive a notification email for every issue and pull request open here?! There is no actual downside in keeping you in 'reviewers list', but the opposite. Your knowledge and experience in this field is greatly appreciated. If you don't mind keep receiving the alert emails, I would just keep you in the list. If you prefer to be removed from that list, please let me know. |
Hello Guilherme, yes I am very interested in OceanGliders activity, I wish I could be more active, please keep me in the loop 🙂 |
@tcarval , fantastic! Please, feel no pressure, and whenever you have a chance to participate, it will be much appreciated. Thanks! |
@OceanGlidersCommunity/format-maintainers , do you agree in adding @emmerbodc in the reviewers list? She is listed as a core author and it would be helpful to have more people able to approve. Feel free to contact me by email if you want help on the procedure to approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers
Type of PR
Related Issues
Dates when it got review approvals
Release checklist
ask reviewers to update their review.
to merge.
according to the final decision.
For maintainers
best to have one single moderator to guide and help this PR to move
forward. It is OK to update the moderador pass it to another one.
Comments
I just noticed that it was missing @emmerbodc in the list of reviewers.