Allow (and test) PHP 8.0 type compatibility #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent enough version is needed for compatiblity with PHP 8
That version is compatible with PHP 8
Many libs might be compatible although they do not advertise it, using that flag will allow us to see if tests pass and to add more tests in the meantime.
3.5.0 is compatible with PHP 8
It should be the easiest one.
…d classes with PHP 8.0 types
…al `ReflectionNamedType` A `ReflectionUnionType` may be encountered at this code location, which will lead to a hard crash of the whole tool when running on PHP 8.0+ with newer code.
…-code` This class was initially introduced to bring in fixes for behavior that was meanwhile patched in upstream libraries. `laminas/laminas-code` is relatively well maintained, and such overrides should be contributed in upstream from now on, with a careful combination of those fixes with @dependabot upgrades
…C), static analysis only on 8.0
Ocramius
added
enhancement
dependencies
…l checks caused by upstream type refinement
…8.0.0` environments
Closed
…ith `ocramius/proxy-manager` Sadly, `thecodingmachine/safe` has too lax dependency ranges ( https://github.com/thecodingmachine/safe/blob/a8ab0876305a4cdaef31b2350fcb9811b5608dbc/composer.json#L106 ), and this trips testing for lower dependency ranges in CI. As previously highlighted multiple times on the internets, `>=` and `*` (unbounded) should be avoided when dealing with dependency ranges, as major releases **will** break, and old dependencies will be installed by accident.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605
Fixes #628
Fixes #637
Fixes #639