feat: project create #115
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "io" | ||
|
|
||
| "github.com/OctopusDeploy/cli/pkg/factory" | ||
| "github.com/OctopusDeploy/cli/pkg/question" | ||
| "github.com/OctopusDeploy/go-octopusdeploy/v2/pkg/client" | ||
| "github.com/OctopusDeploy/go-octopusdeploy/v2/pkg/spaces" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type Dependable interface { | ||
|
There was a problem hiding this comment. I completely understand we're trying to fit within the patterns and idioms of golang... but |
||
| Commit() error | ||
| GenerateAutomationCmd() | ||
| } | ||
|
|
||
| type Dependencies struct { | ||
|
There was a problem hiding this comment. Perhaps From a quick look, it appears as though this struct is meant to carry services (client, asker) and options (space, noprompt) that are commonly used across many commands? If so, some possible naming suggestions?
... something to think about anyway |
||
| Out io.Writer | ||
| Client *client.Client | ||
| Host string | ||
| Space *spaces.Space | ||
| NoPrompt bool | ||
| Ask question.Asker | ||
| CmdPath string | ||
| ShowMessagePrefix bool | ||
| } | ||
|
|
||
| func NewDependencies(f factory.Factory, cmd *cobra.Command) *Dependencies { | ||
| client, err := f.GetSpacedClient() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| return &Dependencies{ | ||
| Ask: f.Ask, | ||
| CmdPath: cmd.CommandPath(), | ||
| Out: cmd.OutOrStdout(), | ||
| Client: client, | ||
| Host: f.GetCurrentHost(), | ||
| NoPrompt: !f.IsPromptEnabled(), | ||
| Space: f.GetCurrentSpace(), | ||
| } | ||
| } | ||
|
|
||
| func NewDependenciesFromExisting(opts *Dependencies, cmdPath string) *Dependencies { | ||
| return &Dependencies{ | ||
| Ask: opts.Ask, | ||
| CmdPath: cmdPath, | ||
| Out: opts.Out, | ||
| Client: opts.Client, | ||
| Host: opts.Host, | ||
| NoPrompt: opts.NoPrompt, | ||
| Space: opts.Space, | ||
| ShowMessagePrefix: true, | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q for @domenicsim1
Given that this isn't a command itself, should it go under the
cmddirectory structure, or should it go under just pkg or pkg/somethingelse?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, although it is suppose to be the basis of cmds. Not sure yet, happy to leave it for now.