chore: Fix small error and warnings in tests, use dockerhub for octopus server image rather than packages.octopushq #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borland
changed the title
rain-on
reviewed
Feb 19, 2024
domenicsim1
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the tests didn't build or run locally because "slices" in
fakesurvey.godidn't exist; the package name was wrong or had changed.I fixed that, and a few other small lint warnings while I had it open. I verified all tests pass including integration tests.
I also changed the docker image the tests are using over to the official one on dockerhub rather than our internal docker.packages.octopushq.com -- dockerhub is faster, and we only need the internal one if we are targeting some feature that has not been released to GA self-host customers yet; which is not currently the case.