fix: Add ability to escape special character when parse variables argument #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuyPhanNguyen
requested review from
hnrkndrssn,
benPearce1 and
IsaacCalligeros95
…e statement start = idx + 1
benPearce1
reviewed
Jun 24, 2024
pkg/cmd/runbook/run/run.go
Outdated
| @@ -181,7 +181,7 @@ func runbookRun(cmd *cobra.Command, f factory.Factory, flags *RunFlags) error { | |||
| return err | |||
| } | |||
|
|
|||
| parsedVariables, err := executionscommon.ParseVariableStringArray(flags.Variables.Value) | |||
| parsedVariables, err := executionscommon.ParseVariableStringArray(flags.Variables.Value, false) | |||
There was a problem hiding this comment.
if we just remove the enableEscape parameter, this will work for runbook runs too
benPearce1
requested changes
Jun 24, 2024
benPearce1
approved these changes
Jun 24, 2024
HuyPhanNguyen
deleted the
huy/2023/3/sc-82129-handle-special-character-in-variable-name
branch
benPearce1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support escape
\:when parse inrelease deploy --variable "Test\:Prompt:Value1"BEGIN_COMMIT_OVERRIDE
fix: Add ability to escape special character when parsing variables argument
END_COMMIT_OVERRIDE