Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle non-nil fields in task wait #422

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: handle non-nil fields in task wait #422

merged 1 commit into from
Sep 20, 2024

Conversation

jameschensmith
Copy link
Contributor

@jameschensmith jameschensmith commented Sep 19, 2024 •
edited
Loading

Summary

Handles non-nil FinishedSuccessfully in non-completed tasks by checking if the task is completed first before adding to list of failed tasks.

Fixes #421.

@jameschensmith @NonlinearFruit
fix: handle non-nil fields in task wait
5381ed1 
Co-authored-by: NonlinearFruit <1123benji5813@gmail.com>
@jameschensmith jameschensmith marked this pull request as ready for review September 19, 2024 14:50
@jameschensmith jameschensmith mentioned this pull request Sep 19, 2024
Closed
hnrkndrssn
hnrkndrssn approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@hnrkndrssn hnrkndrssn merged commit 6d20dd9 into OctopusDeploy:main Sep 20, 2024
1 check passed
@hnrkndrssn hnrkndrssn mentioned this pull request Sep 20, 2024
Closed
@team-integrations-fnm-bot team-integrations-fnm-bot mentioned this pull request Sep 20, 2024
Merged
@jameschensmith jameschensmith deleted the fix/handle-non-nil-task-fields branch September 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnrkndrssn hnrkndrssn hnrkndrssn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One or more deployment tasks failed
2 participants
@jameschensmith @hnrkndrssn