Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accounts slugs #87

Merged
merged 3 commits into from
Sep 29, 2022
Merged

feat: accounts slugs #87

merged 3 commits into from
Sep 29, 2022

Conversation

domenicsim1
Copy link
Collaborator

No description provided.

@domenicsim1 domenicsim1 requested a review from a team September 25, 2022 20:42
borland
borland requested changes Sep 26, 2022
View reviewed changes
pkg/cmd/account/aws/create/create_test.go Outdated Show resolved Hide resolved
pkg/cmd/account/aws/create/create_test.go Show resolved Hide resolved
pkg/cmd/account/aws/create/create_test.go Show resolved Hide resolved
pkg/cmd/account/aws/list/list.go Show resolved Hide resolved
pkg/cmd/account/azure/create/create_test.go Show resolved Hide resolved
pkg/cmd/account/ssh/create/create_test.go Outdated Show resolved Hide resolved
slewis74
slewis74 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@slewis74 slewis74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking 👍

Per @borland 's comment, a few of the tests have Propmt in the name, rather than Prompt, which would be worth fixing.

@domenicsim1 domenicsim1 merged commit 724f365 into main Sep 29, 2022
@domenicsim1 domenicsim1 deleted the feat/account_slugs branch September 29, 2022 02:29
@team-integrations-fnm-bot team-integrations-fnm-bot mentioned this pull request Sep 29, 2022
Merged
This was referenced Jul 28, 2023
Closed
Merged
@team-integrations-fnm-bot team-integrations-fnm-bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borland borland borland approved these changes

@slewis74 slewis74 slewis74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenicsim1 @borland @slewis74